adding subid management to the ipa role #221

danlavu · 2025-11-18T22:03:27Z

No description provided.

gemini-code-assist · 2025-11-18T22:03:41Z

Summary of Changes

Hello @danlavu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the sssd_test_framework by introducing robust capabilities for managing IPA subordinate IDs (subids). It includes a new general-purpose utility for parsing delimited output, a dedicated class for interacting with IPA subid commands, and integrates this functionality seamlessly into the existing IPA role. The changes are supported by new unit tests, ensuring the reliability of the added parsing logic.

Highlights

New Utility Function: Introduced a new delimiter_parse function in sssd_test_framework/misc/__init__.py to efficiently parse delimited lines of output into a dictionary, handling various delimiters.
IPA SubID Management: Added a new IPASubID class to sssd_test_framework/roles/ipa.py for comprehensive management of IPA subordinate IDs. This class provides methods to generate, show, and find subid information.
IPA Role Integration: Integrated the IPASubID functionality into the main IPA role by adding a subid method, allowing easy access to subid management from an IPA object.
Unit Tests: Included new parameterized unit tests in tests/test_misc.py to ensure the correct functionality and robustness of the newly added delimiter_parse utility function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds functionality for managing IPA subids. A new helper function delimiter_parse is introduced to parse colon-delimited output, along with a new IPASubID class in the ipa role to manage subid objects.

My review has identified a few issues:

The new delimiter_parse function has incorrect type hints and lacks robustness.
The IPASubID class has an unused password parameter and a bug in the generate method where string values are assigned to integer-typed attributes without conversion.
The new test for delimiter_parse is structured incorrectly and will fail.

I've provided suggestions to fix these issues. Overall, the changes are a good addition, but these corrections are needed for correctness and maintainability.

sssd_test_framework/misc/__init__.py

sssd_test_framework/roles/ipa.py

tests/test_misc.py

sssd_test_framework/roles/ipa.py

danlavu · 2025-11-20T15:43:27Z

Not ready for review anymore, changing the design.

sssd_test_framework/utils/sssd.py

sssd_test_framework/misc/__init__.py

sssd_test_framework/utils/tools.py

sssd_test_framework/roles/ipa.py

alexey-tikhonov · 2025-11-24T16:59:23Z

Most of my comments were addressed - thank you, but I'd like an input from @pbrezina on two items:

jakub-vavra-cz

LGTM

danlavu requested a review from alexey-tikhonov November 18, 2025 22:03

danlavu assigned danlavu and alexey-tikhonov Nov 18, 2025

danlavu added the Waiting for review label Nov 18, 2025

gemini-code-assist bot reviewed Nov 18, 2025

View reviewed changes

sssd_test_framework/misc/__init__.py Outdated Show resolved Hide resolved

sssd_test_framework/roles/ipa.py Outdated Show resolved Hide resolved

tests/test_misc.py Show resolved Hide resolved

sssd_test_framework/roles/ipa.py Outdated Show resolved Hide resolved

danlavu force-pushed the subids branch 3 times, most recently from 3e0b84f to c8a7b97 Compare November 19, 2025 22:56

danlavu requested a review from jakub-vavra-cz November 20, 2025 13:48

danlavu assigned jakub-vavra-cz Nov 20, 2025

danlavu removed the Waiting for review label Nov 20, 2025

danlavu marked this pull request as draft November 20, 2025 15:43

danlavu force-pushed the subids branch from c8a7b97 to 09485dc Compare November 22, 2025 06:47

danlavu marked this pull request as ready for review November 22, 2025 06:49

danlavu added the Waiting for review label Nov 22, 2025

danlavu mentioned this pull request Nov 22, 2025

adding subid test SSSD/sssd#8225

Open

danlavu commented Nov 22, 2025

View reviewed changes

sssd_test_framework/utils/sssd.py Outdated Show resolved Hide resolved